[SPARK-56186][PYTHON] Retire pypy#54988
Closed
gaogaotiantian wants to merge 1 commit intoapache:masterfrom
Closed
Conversation
Member
|
Merged to master. |
| hadoop: hadoop3 | ||
| envs: >- | ||
| { | ||
| "PYSPARK_IMAGE_TO_TEST": "pypy-310", |
Contributor
There was a problem hiding this comment.
since we remove the pypy3.10 workflow file, I think we don't need to keep its docker file? @gaogaotiantian
Contributor
Author
There was a problem hiding this comment.
The docker file was kept to run 4.0/4.1 pypy tests (it was used there right?). We can drop support for pypy from 4.2 but we can't drop it for previous versions.
Contributor
There was a problem hiding this comment.
I think removing it from master branch won't affect 4.0/4.1, since we use the branchs as the tags:
e.g. in https://github.com/apache/spark/actions/runs/23605397532/job/68748707119
the image is
Starting job container
/usr/bin/docker --config /home/runner/work/_temp/.docker_e68d0502-441d-4d67-9d06-ff417888c8b7 login ghcr.io -u dongjoon-hyun --password-stdin
/usr/bin/docker --config /home/runner/work/_temp/.docker_e68d0502-441d-4d67-9d06-ff417888c8b7 pull ghcr.io/apache/apache-spark-ci-image-pyspark-pypy-310:branch-4.1-23605397532
with tag branch-4.1-23605397532
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
We retire pypy
Why are the changes needed?
We had a discussion in https://lists.apache.org/thread/glcq0zgr33sozo7y4y7jqph24yh3m92p about dropping support for pypy and we have many +1s and no -1s.
numpydropped support for pypy and pypy is not really in active development.Does this PR introduce any user-facing change?
Yes, we don't officially support pypy anymore. We still expect most of the old pypy code to work but we should not make any promises.
How was this patch tested?
CI.
Was this patch authored or co-authored using generative AI tooling?
No.